Fix a few DSL APIs #580
Merged
Fix a few DSL APIs #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map to `.newlineSequence` instead of `.newline`, which allows it to create the correct consumer. rdar://96330096
Explicitly disambiguate the fact we're talking about `.`, which does not match newlines unless in single line mode.
This time as a "true any" that matches any character, including newlines.
This should map to `.any`, not `.dot`. rdar://96509234
This enum will start including cases that only the DSL can use, so move it off the AST.
Introduce `startOfInput` and `endOfInput` assertion kinds, and map the DSL to them such that they do not depend on matching options. rdar://97029630
rdar://97029702
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
CharacterClass.newlineSequencesuch that it doesn't crash,CharacterClass.anysuch that it matches newlines, and implementCharacterClass.anyNonNewline.Also fix
Anchor.startOfLineandAnchor.endOfLinesuch that they always match newlines.Resolves #537 (rdar://96330096)
Resolves #553 (rdar://96509234)
Resolves #571 (rdar://97029630)
Resolves #539 (rdar://97029702)